Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokens value and add transparent color #2452

Merged

Conversation

yangwooseong
Copy link
Collaborator

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

  • None

Summary

  • 색상을 변경하고 transparent 컬러를 추가합니다. transparent 컬러는 tertiary 버튼의 hovered color 를 얻기 위해 사용됩니다.

Details

blue
300 7D9EFA

cobalt
300 71B9F5
200 8DCAFC
100 A1D5FF

green
300 68CC7F
200 84E09A

orange 200 FFB070

Breaking change? (Yes/No)

  • No

References

@yangwooseong yangwooseong added the bezier-tokens Issue or PR related to bezier-tokens label Oct 10, 2024
@yangwooseong yangwooseong self-assigned this Oct 10, 2024
Copy link

channeltalk bot commented Oct 10, 2024

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 4dd2460

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (68438c2) to head (4dd2460).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2452   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files         140      140           
  Lines        2924     2924           
  Branches      882      895   +13     
=======================================
  Hits         2451     2451           
+ Misses        468      443   -25     
- Partials        5       30   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@yangwooseong yangwooseong merged commit 8be075f into channel-io:main Oct 11, 2024
9 checks passed
@yangwooseong yangwooseong deleted the WEB-4757/add-transparent-tokens branch October 11, 2024 04:02
@sungik-choi
Copy link
Contributor

@yangwooseong changeset 추가해주세요! 저도 리뷰 때 놓쳤네요

yangwooseong added a commit that referenced this pull request Oct 11, 2024
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

None

## Summary

<!-- Please brief explanation of the changes made -->

#2452 에서 누락된 changeset 을 추가합니다. 이 PR이 머지되서 changesets PR이 생성되면 Changelog
안에 있는 PR 번호를 직접 수정할 예정입니다.

## Details

<!-- Please elaborate description of the changes -->

None

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

None
@yangwooseong yangwooseong linked an issue Nov 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bezier-tokens Issue or PR related to bezier-tokens
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants